Re: [PATCH] crypto: qat - fix out-of-bounds read

On Fri, Feb 03, 2023 at 06:36:22AM +0000, Giovanni Cabiddu wrote:

The content descriptor structure (cd) is already initialized to zero before the function qat_alg_skcipher_init_com() is called. This is done in (1) qat_alg_skcipher_newkey() implicitly by dma_alloc_coherent(), the first time setkey() is called for a tfm or

Sorry but what zeroes the memory in this case? The only zeroing I can find in newkey is when you free the memory.

(2) qat_alg_skcipher_rekey() explicitly, for subsequent calls to sekey().

This looks fine.

Thanks,