Re: [PATCH 1/3] ext4: Wait for outstanding dio during truncate in nojournal mode

On Wed, May 22, 2019 at 11:03:15AM +0200, Jan Kara wrote:

We didn't wait for outstanding direct IO during truncate in nojournal mode (as we skip orphan handling in that case). This can lead to fs corruption or stale data exposure if truncate ends up freeing blocks and these get reallocated before direct IO finishes. Fix the condition determining whether the wait is necessary.

CC: stable@vger.kernel.org Fixes: 1c9114f9c0f1 ("ext4: serialize unlocked dio reads with truncate") Reviewed-by: Ira Weiny ira.weiny@intel.com Signed-off-by: Jan Kara jack@suse.cz

Thanks, applied.

- Ted