On 8/19/21 3:24 AM, Lukasz Majczak wrote:
Sparse warnings triggered truncating the IDs of some platform device tables. Unfortunately kbl_da7219_max98373 was also truncated. This patch is reverting the original ID. Tested on Atlas chromebook.
Instead of reverting, how about changing the remaining occurrences of the old name in the machine driver?
sound/soc/intel/boards/kbl_da7219_max98927.c: if (!strcmp(pdev->name, "kbl_da7219_max98373") || sound/soc/intel/boards/kbl_da7219_max98927.c: .name = "kbl_da7219_max98373",
Fixes: 94efd726b947 ("ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters") Cc: stable@vger.kernel.org # 5.4+ Tested-by: Lukasz Majczak lma@semihalf.com Signed-off-by: Lukasz Majczak lma@semihalf.com Suggested-by: Cezary Rojewski cezary.rojewski@intel.com
sound/soc/intel/common/soc-acpi-intel-kbl-match.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c index 741bf2f9e081..8cab91a00b1a 100644 --- a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c +++ b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c @@ -113,7 +113,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = { }, { .id = "DLGS7219",
.drv_name = "kbl_da7219_mx98373",
.fw_filename = "intel/dsp_fw_kbl.bin", .machine_quirk = snd_soc_acpi_codec_list, .quirk_data = &kbl_7219_98373_codecs,.drv_name = "kbl_da7219_max98373",