Re: [Regression 6.1.y] From "cifs: Fix flushing, invalidation and file size with copy_file_range()"

Here is a patch similar to what David suggested. Seems straightforward fix. See attached. I did limited testing on it tonight with 6.1 (will do more tomorrow, but feedback welcome) but it did fix the regression in xfstest generic/001 mentioned in this thread.

On Fri, Jan 12, 2024 at 8:26 AM David Howells dhowells@redhat.com wrote:

gregkh@linuxfoundation.org gregkh@linuxfoundation.org wrote:

...

I guess I can just revert the single commit here? Can someone send me the revert that I need to do so as I get it right?

In cifs_flush_folio() the error check for filemap_get_folio() just needs changing to check !folio instead of IS_ERR(folio).

David

-- Thanks,

Steve