On Thu, 9 Oct 2025 09:11:06 +0200 Geert Uytterhoeven geert@linux-m68k.org wrote:
Hi Andrew,
On Thu, 9 Oct 2025 at 06:04, Andrew Morton akpm@linux-foundation.org wrote:
On Thu, 9 Oct 2025 10:01:18 +0800 Lance Yang lance.yang@linux.dev wrote:
I think we fundamentally disagree on whether this fix for known false-positive warnings is needed for -stable.
Having the kernel send scary warnings to our users is really bad behavior. And if we don't fix it, people will keep reporting it.
As the issue is present in v6.16 and v6.17, I think that warrants -stable.
And removing a WARN_ON is a perfectly good way of fixing it. The kernel has 19,000 WARNs, probably seven of which are useful :(
Right. And there is panic_on_warn...
Which, like panic_on_oops, panics before syslogd has a chance to write the error message to /var/log/kernel. Both are set in some environments.
Tracking down those crashes is a right PITA.
David
Gr{oetje,eeting}s,
Geert-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds