On 11/5/25 05:29, Damien Le Moal wrote:
On 11/4/25 21:50, Yongpeng Yang wrote:
From: Yongpeng Yang yangyongpeng@xiaomi.com
sb_min_blocksize() may return 0. Check its return value to avoid opt->blocksize and sb->s_blocksize is 0.
Cc: stable@vger.kernel.org # v6.15 Fixes: 1b17a46c9243e9 ("isofs: convert isofs to use the new mount API") Reviewed-by: Jan Kara jack@suse.cz Reviewed-by: Christoph Hellwig hch@lst.de Signed-off-by: Yongpeng Yang yangyongpeng@xiaomi.com
fs/isofs/inode.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c index 6f0e6b19383c..ad3143d4066b 100644 --- a/fs/isofs/inode.c +++ b/fs/isofs/inode.c @@ -610,6 +610,11 @@ static int isofs_fill_super(struct super_block *s, struct fs_context *fc) goto out_freesbi; } opt->blocksize = sb_min_blocksize(s, opt->blocksize);
- if (!opt->blocksize) {
printk(KERN_ERR"ISOFS: unable to set blocksize\n");Nit: using pr_err() maybe better here ? Not sure what isofs prefers.
Thanks for the review. I checked fs/isofs/inode.c, and other functions seem to prefer using "printk(KERN_ERR|KERN_DEBUG|KERN_WARNING ...)" rather than "pr_err|pr_debug|pr_warn".
Yongpeng,
goto out_freesbi;- }
sbi->s_high_sierra = 0; /* default is iso9660 */ sbi->s_session = opt->session;