Re: [PATCH net 1/7] can: j1939: Fix UAF in j1939_sk_match_filter during setsockopt(SO_J1939_FILTER)

Hi Jakub,

On Thu, Oct 05, 2023 at 09:44:21AM -0700, Jakub Kicinski wrote:

On Thu, 5 Oct 2023 11:46:33 +0200 Marc Kleine-Budde wrote:

...

Lock jsk->sk to prevent UAF when setsockopt(..., SO_J1939_FILTER, ...) modifies jsk->filters while receiving packets.

Doesn't it potentially introduce sleep in atomic?

j1939_sk_recv_match() spin_lock_bh(&priv->j1939_socks_lock); j1939_sk_recv_match_one() j1939_sk_match_filter() lock_sock() sleep

Good point! Thank you for the review.

@Sili Luo, can you please take a look at this?

Regards, Oleksij