On Mon, May 27, 2019 at 10:09:32PM +0100, Ben Hutchings wrote:
There are commits in the 4.14, 4.19 and 5.0 stable branches that claim to be backports of:
commit 26528be6720bb40bc8844e97ee73a37e530e9c5e Author: Todd Kjos tkjos@android.com Date: Thu Feb 14 15:22:57 2019 -0800
binder: fix handling of misaligned binder object
However the source changes actually match:
commit 5cec2d2e5839f9c0fec319c523a911e0a7fd299f Author: Todd Kjos tkjos@android.com Date: Fri Mar 1 15:06:06 2019 -0800
binder: fix race between munmap() and direct reclaim
So far as I can see, the former fixes a bug only introduced in 5.1 and the latter fixes an older bug, so the changes are correct and only the metadata is not.
Similar mix-ups have happened before and I'm a little disturbed that this keeps happening. In any case, you may want to revert and re-apply with correct metadata.
Note, these backports came directly from Todd, so he can provide more information about them. Todd, did something get messed up on your end and do we need to include another patch to fix this up?
thanks,
greg k-h