On Wed, Aug 13, 2025 at 05:31:00AM +0200, Thorsten Leemhuis wrote:
On 12.08.25 19:31, Greg Kroah-Hartman wrote:
6.16-stable review patch. If anyone has any objections, please let me know.
From: Ian Rogers irogers@google.com
[ Upstream commit 5b546de9cc177936a3ed07d7d46ef072db4fdbab ]
The string comparisons were overly broad and could fire for the incorrect PMU and events. Switch to using the config in the attribute then add a perf test to confirm the attribute config values match those of parsed events of that name and don't match others. This exposed matches for slots events that shouldn't have matched as the slots fixed counter event, such as topdown.slots_p.
This caused the following build error for me when building perf on Fedora x86_64:
arch/x86/tests/topdown.c: In function ‘event_cb’: arch/x86/tests/topdown.c:53:25: error: implicit declaration of function ‘pr_debug’ [-Wimplicit-function-declaration] 53 | pr_debug("Broken topdown information for '%s'\n", evsel__name(evsel)); | ^~~~~~~~ make[6]: *** [/builddir/build/BUILD/kernel-6.16.1-build/kernel-6.16.1-rc1/linux-6.16.1-0.rc1.200.vanilla.fc42.x86_64/tools/build/Makefile.build:85: arch/x86/tests/topdown.o] Error 1 make[6]: *** Waiting for unfinished jobs....
Reverting fixed the problem. Full log: https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/stable-rc...
Ciao, Thorsten
Thanks, I've now deleted this patch from the queue.
greg k-h