Hi Mark,
On 6-Nov-25 12:34 PM, Mark Brown wrote:
On Sun, 02 Nov 2025 20:09:21 +0100, Hans de Goede wrote:
Since commit d24cfee7f63d ("spi: Fix acpi deferred irq probe"), the acpi_dev_gpio_irq_get() call gets delayed till spi_probe() is called on the SPI device.
If there is no driver for the SPI device then the move to spi_probe() results in acpi_dev_gpio_irq_get() never getting called. This may cause problems by leaving the GPIO pin floating because this call is responsible for setting up the GPIO pin direction and/or bias according to the values from the ACPI tables.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: Try to get ACPI GPIO IRQ earlier commit: 3cd2018e15b3d66d2187d92867e265f45ad79e6f
Thank you.
I believe that Andy's Reviewed-by was intended for a v2 with extending the comment with an extra paragraph with something like:
"TODO: ideally the setup of the GPIO should be handled in a generic manner in the ACPI/gpiolib core code".
Since you've already merged this now l'll prepare a follow-up patch to extend the comment with that info.
Regards,
Hans