From: Vijendar Mukunda Vijendar.Mukunda@amd.com
[ Upstream commit ab72bfce7647522e01a181e3600c3d14ff5c143e ]
Add new pci id for AMD GPU display HD audio controller(device id- 0xab40).
Signed-off-by: Vijendar Mukunda Vijendar.Mukunda@amd.com Reviewed-by: Alex Deucher alexander.deucher@amd.com Link: https://patch.msgid.link/20250529053838.2350071-1-Vijendar.Mukunda@amd.com Signed-off-by: Takashi Iwai tiwai@suse.de Signed-off-by: Sasha Levin sashal@kernel.org ---
Based on my analysis of the commit and the similar historical commits provided, here is my assessment:
**YES**
This commit should be backported to stable kernel trees based on the following extensive analysis:
**1. Hardware Support Fix Pattern:** The commit follows the exact same pattern as the historical commits marked "YES" for backporting (Similar Commits #2, #3, and #4). All of these commits: - Add new PCI device IDs for hardware support - Use identical driver configuration (`AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | AZX_DCAPS_PM_RUNTIME`) - Are small, self-contained changes with minimal risk
**2. Code Analysis:** The change adds exactly one new PCI device entry: ```c { PCI_VDEVICE(ATI, 0xab40), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | AZX_DCAPS_PM_RUNTIME }, ```
This entry is inserted in the correct sequential order between existing AMD GPU audio devices (after 0xab38) and follows the exact same pattern as all surrounding entries. The driver data flags used are: - `AZX_DRIVER_ATIHDMI_NS`: Standard ATI HDMI driver - `AZX_DCAPS_PRESET_ATI_HDMI_NS`: ATI HDMI preset capabilities - `AZX_DCAPS_PM_RUNTIME`: Runtime power management support
**3. Risk Assessment - Minimal:** - **No algorithmic changes**: Pure PCI ID table addition - **No new code paths**: Uses existing, well-tested driver infrastructure - **No configuration changes**: Same capabilities as neighboring AMD GPU devices - **No architectural impact**: Confined to PCI device recognition - **Regression risk**: Nearly zero - only affects this specific AMD GPU (device ID 0xab40)
**4. User Impact - Significant:** This enables HD audio functionality for users with new AMD GPU hardware (device ID 0xab40). Without this change, the audio component of these GPUs would not be recognized by the kernel, leaving users without audio output capabilities on affected systems.
**5. Stable Tree Criteria Compliance:** - ✅ **Fixes important bug**: Lack of audio support on new hardware - ✅ **Minimal risk**: PCI ID additions have extremely low regression potential - ✅ **Small and contained**: Single line addition following established pattern - ✅ **No new features**: Pure hardware enablement - ✅ **Clear benefit**: Enables audio on new AMD GPUs
**6. Historical Precedent:** Similar Commits #2, #3, and #4 (all marked "YES") demonstrate that AMD/ATI GPU audio PCI ID additions are consistently considered appropriate for stable backporting. The only "NO" examples (Similar Commits #1 and #5) were either preparatory changes for future features or lacked hardware urgency.
**7. Maintainer Endorsement:** The commit has proper sign-offs including review by Alex Deucher (AMD maintainer), indicating technical correctness and hardware necessity.
This commit perfectly fits the stable tree guidelines: it's a minimal, safe hardware enablement fix that provides significant user benefit with virtually no regression risk.
sound/pci/hda/hda_intel.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 407bbf9264ac4..48c00e0ddd722 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2791,6 +2791,9 @@ static const struct pci_device_id azx_ids[] = { { PCI_DEVICE(0x1002, 0xab38), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | AZX_DCAPS_PM_RUNTIME }, + { PCI_VDEVICE(ATI, 0xab40), + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS | + AZX_DCAPS_PM_RUNTIME }, /* GLENFLY */ { PCI_DEVICE(PCI_VENDOR_ID_GLENFLY, PCI_ANY_ID), .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8,