From: Jackie Dong xy-jackie@139.com
[ Upstream commit 4722727373533b53489b66d3436b50ac156f23bf ]
Support mute LED on keyboard for Lenovo Yoga series products with Realtek ALC287 chipset.
Tested on Lenovo Slim Pro 7 14APH8.
[ slight comment cleanup by tiwai ]
Signed-off-by: Jackie Dong xy-jackie@139.com Link: https://patch.msgid.link/20250714094655.4657-1-xy-jackie@139.com Signed-off-by: Takashi Iwai tiwai@suse.de Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
Now I understand the pattern. Let me analyze this commit thoroughly:
**YES**
This commit should be backported to stable kernel trees for the following reasons:
1. **Bug Fix for Hardware Functionality**: The commit adds mute LED support for Lenovo Yoga series laptops with ALC287 chipset. This is a hardware enablement fix that allows the mute LED indicators on the keyboard to function correctly. Without this fix, users cannot see the visual feedback for mute status, which is an important usability feature.
2. **Small and Contained Change**: The modification is minimal - it only adds a single line `hda_fixup_ideapad_acpi(codec, fix, action);` to an existing fixup function. This is a very low-risk change that: - Uses an already existing helper function (`hda_fixup_ideapad_acpi`) - Only affects the specific device (Lenovo Yoga9 14IAP7) - Doesn't introduce new functionality, just enables existing LED support
3. **Follows Established Pattern**: The commit follows the same pattern as similar commits marked with "Backport Status: YES": - Similar Commit #1: Added LED support for ThinkCentre M series - Similar Commit #3: Added LED support for HP laptops - Similar Commit #4: Added LED support for HP Laptop 14-dq2xxx - Similar Commit #5: Added quirk for Lenovo Yoga9 14IAP7 (bass speakers)
4. **No Architectural Changes**: The change: - Doesn't modify any core subsystems - Doesn't introduce new APIs or data structures - Only affects the specific hardware when detected - Uses existing infrastructure (ideapad_hotkey_led_helper.c)
5. **User-Facing Bug**: This fixes a user-visible issue where mute/micmute LED indicators don't work on affected hardware. This is exactly the type of hardware enablement fix that stable kernels should receive.
6. **Safe Implementation**: The `hda_fixup_ideapad_acpi` function includes proper checks: - Only runs during HDA_FIXUP_ACT_PRE_PROBE - Checks if the device is actually an IdeaPad before applying the fix - Falls back gracefully if CONFIG_IDEAPAD_LAPTOP is not enabled
The commit is a perfect candidate for stable backporting as it fixes a specific hardware issue with minimal risk and follows established patterns for similar hardware enablement fixes.
sound/pci/hda/patch_realtek.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index f7bb97230201f..55739b913359a 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7497,6 +7497,9 @@ static void alc287_fixup_yoga9_14iap7_bass_spk_pin(struct hda_codec *codec, }; struct alc_spec *spec = codec->spec;
+ /* Support Audio mute LED and Mic mute LED on keyboard */ + hda_fixup_ideapad_acpi(codec, fix, action); + switch (action) { case HDA_FIXUP_ACT_PRE_PROBE: snd_hda_apply_pincfgs(codec, pincfgs);