Re: [PATCH] NFC: Fix error handling in nfc_genl_dump_targets

On Sun, 2025-12-14 at 13:54 +0000, David Laight wrote:

On Sun, 14 Dec 2025 21:17:26 +0800 Ma Ke make24@iscas.ac.cn wrote:

...

nfc_genl_dump_targets() increments the device reference count via nfc_get_device() but fails to decrement it properly. nfc_get_device() calls class_find_device() which internally calls get_device() to increment the reference count. No corresponding put_device() is made to decrement the reference count.

Add proper reference count decrementing using nfc_put_device() when the dump operation completes or encounters an error, ensuring balanced reference counting.

Found by code review.

Is that some half-hearted AI code review?

Probably. They also resubmitted the same patch after being told 3 weeks ago to go away.

johannes