Re: [PATCH 5.10 108/299] platform/x86: intel_pmc_core: Dont use global pmcdev in quirks

On Mon, May 10, 2021 at 02:12:40PM +0200, Pavel Machek wrote:

Hi!

...

From: David E. Box david.e.box@linux.intel.com

[ Upstream commit c9f86d6ca6b5e23d30d16ade4b9fff5b922a610a ]

The DMI callbacks, used for quirks, currently access the PMC by getting the address a global pmc_dev struct. Instead, have the callbacks set a global quirk specific variable. In probe, after calling dmi_check_system(), pass pmc_dev to a function that will handle each quirk if its variable condition is met. This allows removing the global pmc_dev later.

This does not fix a bug.. it is preparation for further cleanups that are not queued to 5.10 stable. So this should not be in 5.10 either.

I'll leave this for now, it will be helpful for later.

thanks,

greg k-h