RE: [PATCH net,v2] net: mana: Fix accessing freed irq affinity_hint

-----Original Message----- From: Jakub Kicinski kuba@kernel.org Sent: Thursday, February 2, 2023 2:38 PM To: Haiyang Zhang haiyangz@microsoft.com Cc: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; Dexuan Cui decui@microsoft.com; KY Srinivasan kys@microsoft.com; Paul Rosswurm paulros@microsoft.com; olaf@aepfle.de; vkuznets@redhat.com; davem@davemloft.net; linux-kernel@vger.kernel.org; stable@vger.kernel.org Subject: Re: [PATCH net,v2] net: mana: Fix accessing freed irq affinity_hint

On Wed, 1 Feb 2023 13:46:53 -0800 Haiyang Zhang wrote:

...

• irq_set_affinity_and_hint(irq,
  

cpumask_of(cpumask_local_spread

...

• 			  (i, gc->numa_node)));
  

The line break here looks ugly. Please use a local variable for the mask or the cpu.

Will do.