From: Srinivas Pandruvada srinivas.pandruvada@linux.intel.com
[ Upstream commit ddf5ffff3a5fe95bed178f5554596b93c52afbc9 ]
Add ACPI ID for Nova Lake.
Signed-off-by: Srinivas Pandruvada srinivas.pandruvada@linux.intel.com Link: https://patch.msgid.link/20251110235041.123685-1-srinivas.pandruvada@linux.i... Reviewed-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com Signed-off-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
1. **COMMIT MESSAGE ANALYSIS** - The subject "platform/x86/intel/hid: Add Nova Lake support" and body "Add ACPI ID for Nova Lake" clearly identify this as a hardware enablement patch. - There are no "Fixes:" or "Cc: stable@" tags. While this often signals a feature, simple device ID additions are frequently backported without these tags under specific stable rule exceptions. - The change is signed off by the subsystem maintainer.
2. **DEEP CODE RESEARCH** - **File:** `drivers/platform/x86/intel/hid.c` - **Mechanism:** The `intel_hid` driver relies on an ACPI device ID table (`intel_hid_ids`) to bind to the underlying platform firmware. When the ACPI subsystem enumerates devices, it checks this table. - **The Change:** The commit adds a single line `{ "INTC10F2" }` to this array. This ID corresponds to the Nova Lake platform. - **Impact:** Without this ID, the kernel will fail to load this driver on Nova Lake laptops. Users would experience broken functionality for hotkeys (brightness, volume, WiFi toggle) and 5-button array features (common on 2-in-1s/tablets). - **Context:** The diff shows the immediate predecessor `{ "INTC10F1" }` (Wildcat Lake), confirming that this driver is mature and regularly updated for new Intel generations via this exact mechanism.
3. **STABLE KERNEL RULES ALIGNMENT** - **General Rule:** Usually, new hardware support is not appropriate for stable. - **Exception Check (CRITICAL):** However, the *Stable Kernel Rules* (Documentation/process/stable-kernel-rules.rst) contain a specific exception for **"NEW DEVICE IDs"**. It explicitly states that adding ACPI IDs to existing drivers is allowed. - **Compliance:** - Does the driver exist in stable? **Yes**, `intel/hid.c` is a long-standing driver. - Is the change minimal? **Yes**, it is a one-line data addition. - Is it obviously correct? **Yes**, it strictly follows the pattern of previous platforms.
4. **RISK VS BENEFIT ASSESSMENT** - **Regression Risk:** **Negligible**. The change effectively only executes when the specific ACPI ID `INTC10F2` is present in the system firmware. Existing systems (with different IDs) will skip this entry in the match table, resulting in zero change in behavior for current users. - **Benefit:** High for users of new hardware. It allows enterprise and LTS distributions (which rely on stable kernels) to function correctly on upcoming Nova Lake devices without requiring a full kernel upgrade.
5. **CONCLUSION** This commit is a textbook example of the "New Device ID" exception. It provides necessary hardware enablement for stable kernel users with zero risk of regression for existing users. While it lacks a stable tag, it qualifies for backporting based on the documented rules and the trivial nature of the change.
**YES**
drivers/platform/x86/intel/hid.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c index f25a427cccdac..9c07a7faf18fe 100644 --- a/drivers/platform/x86/intel/hid.c +++ b/drivers/platform/x86/intel/hid.c @@ -55,6 +55,7 @@ static const struct acpi_device_id intel_hid_ids[] = { { "INTC10CB" }, { "INTC10CC" }, { "INTC10F1" }, + { "INTC10F2" }, { } }; MODULE_DEVICE_TABLE(acpi, intel_hid_ids);