From: Max Chou max.chou@realtek.com
[ Upstream commit 32caa197b9b603e20f49fd3a0dffecd0cd620499 ]
Add the support ID(0x0489, 0xE12F) to usb_device_id table for Realtek RTL8852BE-VT.
The device info from /sys/kernel/debug/usb/devices as below.
T: Bus=04 Lev=02 Prnt=02 Port=05 Cnt=01 Dev#= 86 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=0489 ProdID=e12f Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
Signed-off-by: Max Chou max.chou@realtek.com Signed-off-by: Luiz Augusto von Dentz luiz.von.dentz@intel.com Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
## Commit Analysis: Bluetooth: btusb: Add new VID/PID 0x0489/0xE12F for RTL8852BE-VT
### 1. COMMIT MESSAGE ANALYSIS
- **Subject**: Adding a new USB Vendor/Product ID for a Realtek Bluetooth chip variant - **No "Cc: stable@vger.kernel.org"** tag present - **No "Fixes:"** tag present - Commit message includes detailed device info from `/sys/kernel/debug/usb/devices`, confirming this is real hardware that's been tested - Signed off by Realtek engineer (the hardware vendor) and Bluetooth maintainer
### 2. CODE CHANGE ANALYSIS
The diff is extremely simple: ```c + { USB_DEVICE(0x0489, 0xe12f), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH }, ```
- **2 lines added** to the `quirks_table[]` static array - Uses identical `driver_info` flags as the existing RTL8852BE-VT entry (`0x0bda, 0x8520`) - Placed in the appropriate "Realtek 8852BT/8852BE-VT Bluetooth devices" section - No code logic changes whatsoever - just adding an entry to a USB device ID table
### 3. CLASSIFICATION
This falls squarely under the **NEW DEVICE IDs** exception, which is explicitly allowed in stable:
"Adding PCI IDs, USB IDs, ACPI IDs, etc. to existing drivers - These
are trivial one-line additions that enable hardware support"
This is **not** a new feature. The btusb driver already fully supports RTL8852BE-VT devices. This simply registers another VID/PID combination for the same chipset.
### 4. SCOPE AND RISK ASSESSMENT
| Factor | Assessment | |--------|------------| | Lines changed | 2 (minimal) | | Files touched | 1 (`drivers/bluetooth/btusb.c`) | | Complexity | Trivial - static table entry | | Risk | **Extremely low** |
- Change only affects devices matching VID 0x0489 / PID 0xe12f - Cannot regress any existing functionality - No behavioral changes to the driver code itself
### 5. USER IMPACT
- **Without this patch**: Users with this Bluetooth adapter have non- functional hardware - **With this patch**: The adapter is recognized and works with existing Realtek support - **Severity for affected users**: High - complete loss of Bluetooth functionality - This is a real Realtek product (vendor confirmed via signoff)
### 6. STABILITY INDICATORS
- Submitted by Realtek engineer (Max Chou) - hardware vendor - Merged by Bluetooth maintainer (Luiz von Dentz) - Device info in commit message demonstrates the device exists and was tested
### 7. DEPENDENCY CHECK
- No dependencies on other commits - The btusb driver with Realtek support (`BTUSB_REALTEK`) exists in all stable trees - `BTUSB_WIDEBAND_SPEECH` flag is also well-established
---
## Summary
This is a textbook example of a commit that should be backported to stable:
**Benefits**: - Enables real hardware for real users - Zero risk of regression (only affects specific VID/PID) - Trivial 2-line data table addition - Obviously correct - follows exact same pattern as dozens of other entries - Hardware vendor submitted the patch
**Concerns**: - No explicit stable tags (common for device ID additions; maintainers often omit these for routine changes)
The absence of `Cc: stable` is not concerning for device ID additions - they're so routine that many maintainers don't bother tagging them, yet stable maintainers regularly pick them up. This enables users with this Bluetooth adapter to have working hardware on stable kernels without requiring a full kernel upgrade.
**YES**
drivers/bluetooth/btusb.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index cc03c8c38b16f..a5b73e0d271f3 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -585,6 +585,8 @@ static const struct usb_device_id quirks_table[] = { /* Realtek 8852BT/8852BE-VT Bluetooth devices */ { USB_DEVICE(0x0bda, 0x8520), .driver_info = BTUSB_REALTEK | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x0489, 0xe12f), .driver_info = BTUSB_REALTEK | + BTUSB_WIDEBAND_SPEECH },
/* Realtek 8922AE Bluetooth devices */ { USB_DEVICE(0x0bda, 0x8922), .driver_info = BTUSB_REALTEK |