Hello Claudiu-san,
From: Claudiu, Sent: Thursday, February 20, 2025 1:08 AM
From: Claudiu Beznea claudiu.beznea.uj@bp.renesas.com
Assert PLL reset on PHY power off. This saves power.
Fixes: f3b5a8d9b50d ("phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver") Cc: stable@vger.kernel.org Signed-off-by: Claudiu Beznea claudiu.beznea.uj@bp.renesas.com
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c index 5c0ceba09b67..087937407b0b 100644 --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c @@ -537,9 +537,16 @@ static int rcar_gen3_phy_usb2_power_off(struct phy *p) struct rcar_gen3_chan *channel = rphy->ch; int ret = 0;
- scoped_guard(spinlock_irqsave, &channel->lock)
scoped_guard(spinlock_irqsave, &channel->lock) { rphy->powered = false;
if (rcar_gen3_are_all_rphys_power_off(channel)) {u32 val = readl(channel->base + USB2_USBCTR);val |= USB2_USBCTR_PLL_RST;
nit: According to the checkpatch.pl: --- WARNING: Missing a blank line after declarations #30: FILE: drivers/phy/renesas/phy-rcar-gen3-usb2.c:545: + u32 val = readl(channel->base + USB2_USBCTR); + val |= USB2_USBCTR_PLL_RST; ---
Best regards, Yoshihiro Shimoda
writel(val, channel->base + USB2_USBCTR);}- }
- if (channel->vbus) ret = regulator_disable(channel->vbus);
-- 2.43.0