Re: [PATCH] ipvs: use explicitly signed chars

Hi Pablo,

On Wed, Oct 26, 2022 at 2:34 PM Jason A. Donenfeld Jason@zx2c4.com wrote:

The `char` type with no explicit sign is sometimes signed and sometimes unsigned. This code will break on platforms such as arm, where char is unsigned. So mark it here as explicitly signed, so that the todrop_counter decrement and subsequent comparison is correct.

Cc: Pablo Neira Ayuso pablo@netfilter.org Cc: Julian Anastasov ja@ssi.bg Cc: Simon Horman horms@verge.net.au Cc: stable@vger.kernel.org Signed-off-by: Jason A. Donenfeld Jason@zx2c4.com

Wondering if you planned on taking this into nf.git for 6.1?

Thanks, Jason