From: Taehee Yoo ap420073@gmail.com
[ Upstream commit a5bbcbf29089a1252c201b1a7fd38151de355db9 ]
If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic.
Fixes: 82c93a87bf8b ("netdevsim: implement couple of testing devlink health reporters") Fixes: 424be63ad831 ("netdevsim: add UDP tunnel port offload support") Fixes: 4418f862d675 ("netdevsim: implement support for devlink region and snapshots") Fixes: d3cbb907ae57 ("netdevsim: add ACL trap reporting cookie as a metadata") Signed-off-by: Taehee Yoo ap420073@gmail.com Link: https://lore.kernel.org/r/20201115103041.30701-1-ap420073@gmail.com Signed-off-by: Jakub Kicinski kuba@kernel.org Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org --- drivers/net/netdevsim/dev.c | 2 ++ drivers/net/netdevsim/health.c | 1 + drivers/net/netdevsim/udp_tunnels.c | 1 + 3 files changed, 4 insertions(+)
--- a/drivers/net/netdevsim/dev.c +++ b/drivers/net/netdevsim/dev.c @@ -94,6 +94,7 @@ static const struct file_operations nsim .open = simple_open, .write = nsim_dev_take_snapshot_write, .llseek = generic_file_llseek, + .owner = THIS_MODULE, };
static ssize_t nsim_dev_trap_fa_cookie_read(struct file *file, @@ -186,6 +187,7 @@ static const struct file_operations nsim .read = nsim_dev_trap_fa_cookie_read, .write = nsim_dev_trap_fa_cookie_write, .llseek = generic_file_llseek, + .owner = THIS_MODULE, };
static int nsim_dev_debugfs_init(struct nsim_dev *nsim_dev) --- a/drivers/net/netdevsim/health.c +++ b/drivers/net/netdevsim/health.c @@ -261,6 +261,7 @@ static const struct file_operations nsim .open = simple_open, .write = nsim_dev_health_break_write, .llseek = generic_file_llseek, + .owner = THIS_MODULE, };
int nsim_dev_health_init(struct nsim_dev *nsim_dev, struct devlink *devlink) --- a/drivers/net/netdevsim/udp_tunnels.c +++ b/drivers/net/netdevsim/udp_tunnels.c @@ -119,6 +119,7 @@ static const struct file_operations nsim .open = simple_open, .write = nsim_udp_tunnels_info_reset_write, .llseek = generic_file_llseek, + .owner = THIS_MODULE, };
int nsim_udp_tunnels_info_create(struct nsim_dev *nsim_dev,