Re: [PATCH net] net: mana: Remove redundant netdev_lock_ops_to_full() calls

On Mon, Aug 25, 2025 at 05:41:33PM -0700, Jakub Kicinski wrote:

On Mon, 25 Aug 2025 04:03:14 -0700 Saurabh Sengar wrote:

...

NET_SHAPER is always selected for MANA driver. When NET_SHAPER is enabled, netdev_lock_ops_to_full() reduces effectively to only an assert for lock, which is always held in the path when NET_SHAPER is enabled.

Remove the redundant netdev_lock_ops_to_full() call.

Fixes: d5c8f0e4e0cb ("net: mana: Fix potential deadlocks in mana napi ops") Cc: stable@vger.kernel.org

If the call is a nop why is this a stable-worthy fix?

I am fine removing CC and fixes tag. I can send a V2 for it.

- Saurabh