On Thu, 25 Apr 2019 06:35:06 PDT (-0700), Anup Patel wrote:
The Linux kernel will auto-disables all boot consoles whenever it gets a preferred real console.
Currently on RISC-V systems, if we have a real console which is not RISCV SBI console then boot consoles (such as earlycon=sbi) are not auto-disabled when a real console (ttyS0 or ttySIF0) is available. This results in duplicate prints at boot-time after kernel starts using real console (i.e. ttyS0 or ttySIF0) if "earlycon=" kernel parameter was passed by bootloader.
The reason for above issue is that RISCV SBI console always adds itself as preferred console which is causing other real consoles to be not used as preferred console.
Ideally "console=" kernel parameter passed by bootloaders should be the one selecting a preferred real console.
This patch fixes above issue by not forcing RISCV SBI console as preferred console.
Fixes: afa6b1ccfad5 ("tty: New RISC-V SBI console driver") Cc: stable@vger.kernel.org Signed-off-by: Anup Patel anup.patel@wdc.com
drivers/tty/hvc/hvc_riscv_sbi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/tty/hvc/hvc_riscv_sbi.c b/drivers/tty/hvc/hvc_riscv_sbi.c index 75155bde2b88..31f53fa77e4a 100644 --- a/drivers/tty/hvc/hvc_riscv_sbi.c +++ b/drivers/tty/hvc/hvc_riscv_sbi.c @@ -53,7 +53,6 @@ device_initcall(hvc_sbi_init); static int __init hvc_sbi_console_init(void) { hvc_instantiate(0, 0, &hvc_sbi_ops);
- add_preferred_console("hvc", 0, NULL);
return 0; } -- 2.17.1
I merged this. Also, it looks like Exchange is doing something to your patches that makes them a bit difficult to merge. If you don't have a way of fixing that, can you include a pointer to a git tree with a signed commit/tag?