On Sat, Nov 5, 2022 at 2:57 AM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Fri, Nov 04, 2022 at 11:17:45AM -0700, Nick Desaulniers wrote:
On Tue, Nov 01, 2022 at 07:24:13PM +0100, Greg Kroah-Hartman wrote:
I'm announcing the release of the 4.14.297 kernel.
All users of the 4.14 kernel series must upgrade.
The updated 4.14.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git%3Ba=summa...
Hi Greg and stable tree maintainers, Please consider cherry-picking commit 95b980d62d52 ("linux/bits.h: make BIT(), GENMASK(), and friends available in assembly") back to 4.19.y and 4.14.y. It first landed in v5.3-rc1 and applies cleanly to both branches. I did not find any fixups to 95b980d62d52, FWIW.
Otherwise users upgrading to this point release of linux-4.14.y still on versions of the GNU assembler older than v1.28 will observe assembler errors when building this series. See the link below for the error messages.
Please see https://lore.kernel.org/llvm/20221103210748.1343090-1-ndesaulniers@google.co... for more info.
Did you try building with that commit applied? I get the following
I built 4.19 but not 4.14. Sorry! It looks like for 4.14 95b980d62d52 will additionally depend on
commit 2dd8a62c6476 ("linux/const.h: move UL() macro to include/linux/const.h")
which first landed in v4.17-rc1.
That commit will depend on
commit 2a6cc8a6c0cb ("linux/const.h: prefix include guard of uapi/linux/const.h with _UAPI")
which first landed in v4.17-rc1 as well. Looks like they were part of the same series.
So 4.14.y will need the following 3 patches: 1. commit 2a6cc8a6c0cb ("linux/const.h: prefix include guard of uapi/linux/const.h with _UAPI") 2. commit 2dd8a62c6476 ("linux/const.h: move UL() macro to include/linux/const.h") 3. commit 95b980d62d52 ("linux/bits.h: make BIT(), GENMASK(), and friends available in assembly")
2a6cc8a6c0cb will have a minor conflict in include/uapi/linux/const.h because commit a85cbe6159ff ("uapi: move constants from <linux/kernel.h> to <linux/const.h>") was backported before 2a6cc8a6c0cb as b732e14e6218b (in 4.14). Attached is a compile tested (x86 make CC=clang) mbox for 4.14.y. Please let me know if that works for you.
build error when running it through the Android build system:
In file included from /buildbot/src/android/q-common-android-4.14/common/arch/arm64/include/asm/bitops.h:49: /buildbot/src/android/q-common-android-4.14/common/include/asm-generic/bitops/non-atomic.h:60:23: error: implicit declaration of function 'UL' [-Werror,-Wimplicit-function-declaration] unsigned long mask = BIT_MASK(nr); ^ /buildbot/src/android/q-common-android-4.14/common/include/linux/bits.h:10:24: note: expanded from macro 'BIT_MASK' #define BIT_MASK(nr) (UL(1) << ((nr) % BITS_PER_LONG))
So are you sure this is the correct fix?
thanks,
greg k-h