Re: [PATCH net v4 1/2] Revert "net: rtnetlink: Enslave device before bringing it up"

Mon, Jan 08, 2024 at 10:41:02AM CET, nicolas.dichtel@6wind.com wrote:

This reverts commit a4abfa627c3865c37e036bccb681619a50d3d93c.

The patch broke:

...

ip link set dummy0 up ip link set dummy0 master bond0 down

This last command is useful to be able to enslave an interface with only one netlink message.

After discussion, there is no good reason to support:

...

ip link set dummy0 down ip link set dummy0 master bond0 up

because the bond interface already set the slave up when it is up.

Cc: stable@vger.kernel.org Fixes: a4abfa627c38 ("net: rtnetlink: Enslave device before bringing it up") Signed-off-by: Nicolas Dichtel nicolas.dichtel@6wind.com

Reviewed-by: Jiri Pirko jiri@nvidia.com

Thanks!