Re: [PATCH v2] iommu/vt-d: Avoid superfluous IOTLB tracking in lazy mode

Hi Kevin,

On Thu, 9 Feb 2023 02:09:47 +0000, "Tian, Kevin" kevin.tian@intel.com wrote:

...

From: Jacob Pan jacob.jun.pan@linux.intel.com Sent: Thursday, February 9, 2023 2:19 AM

• iommu_iotlb_gather_add_page(domain, gather, iova, size);

• /*

• * We do not use page-selective IOTLB invalidation in flush
  

queue,

• * There is no need to track page and sync iotlb.
  

Domain-selective or

"in flush queue, so there is ..."

...

• * PASID-selective validation are used in the flush queue.  
  

the last sentence can be removed. same meaning as the first one.

sounds good.

...

• */
  

• if (!iommu_iotlb_gather_queued(gather))

• iommu_iotlb_gather_add_page(domain, gather, iova,
  

size);

Reviewed-by: Kevin Tian kevin.tian@intel.com

Thanks,

Jacob