On 16.01.23 00:13, Yu Zhao wrote:
On Sun, Jan 15, 2023 at 6:47 AM msizanoen1 msizanoen@qtmlabs.xyz wrote:
In some cases, memory cgroup migration can be initiated by userspace right after a process was created and right before `lru_gen_add_mm()` is called (e.g. by some program watching a cgroup and moving away any processes it detects[1]), which results in the following sequence of WARNs followed by an Oops as the kernel attempts to perform a `lru_gen_add_mm()` twice on the same `mm`:
...
Fix this by simply leaving the lru_gen alone if it has not been associated with a memcg yet, as it should eventually be assigned to the right cgroup anyway.
v2: Added stable cc tags
Signed-off-by: N/A (patch should not be copyrightable) Cc: stable@vger.kernel.org
Thanks for the fix. Cc'ing stable is the right thing to do. The commit message and the comment styles could be easily adjusted to align with the guidelines.
I don't think the N/A is acceptible though. I fully respect it if you wish to remain anonymous -- I can send a similar fix crediting you as the "anonymous user msizanoen@qtmlabs.xyz" who reported this bug.
Not acceptable:
Documentation/process/submitting-patches.rs
"using your real name (sorry, no pseudonyms or anonymous contributions.)"