Re: [PATCH] crypto: qat - fix out-of-bounds read

On Wed, Feb 01, 2023 at 03:59:44PM +0000, Giovanni Cabiddu wrote: .

@@ -435,8 +435,8 @@ static void qat_alg_skcipher_init_com(struct qat_alg_skcipher_ctx *ctx, } else if (aes_v2_capable && mode == ICP_QAT_HW_CIPHER_CTR_MODE) { ICP_QAT_FW_LA_SLICE_TYPE_SET(header->serv_specif_flags, ICP_QAT_FW_LA_USE_UCS_SLICE_TYPE);

• keylen = round_up(keylen, 16);
  

  memcpy(cd->ucs_aes.key, key, keylen);

• keylen = round_up(keylen, 16);
  

Now cd->ucs_aes.key contains potentially unitialised data, should we zero them?

Thanks,