Re: [PATCH v4 3/3] virtio_balloon: remove the unnecessary 0-initialization

On Tue, Jan 08, 2019 at 12:50:05PM +0800, Wei Wang wrote:

We've changed to kzalloc the vb struct, so no need to 0-initialize this field one more time.

Signed-off-by: Wei Wang wei.w.wang@intel.com Reviewed-by: Cornelia Huck cohuck@redhat.com

---

drivers/virtio/virtio_balloon.c | 1 - 1 file changed, 1 deletion(-)

diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index d48c12c..048959a 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -925,7 +925,6 @@ static int virtballoon_probe(struct virtio_device *vdev) VIRTIO_BALLOON_CMD_ID_STOP); vb->cmd_id_stop = cpu_to_virtio32(vb->vdev, VIRTIO_BALLOON_CMD_ID_STOP);

• vb->num_free_page_blocks = 0;
  

  spin_lock_init(&vb->free_page_list_lock); INIT_LIST_HEAD(&vb->free_page_list); if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) {

-- 2.7.4

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.

</formletter>