This reverts commit 6795801366da0cd3d99e27c37f020a8f16714886.
Even after resolving the page cache corruption issue [0], problems persist with XFS large folios. Recently, we encountered random core dumps in one of our Hadoop services. These core dumps occurred sporadically over several weeks, and it took significant effort to pinpoint XFS large folios as the root cause. After reverting the related commit, the issues disappeared entirely. Given these issues, it seems premature to adopt large folios on stable kernels. Therefore, we propose reverting this change.
Link: https://lore.kernel.org/all/20241001210625.95825-1-ryncsn@gmail.com/ [0] Signed-off-by: Yafang Shao laoar.shao@gmail.com --- fs/xfs/xfs_icache.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c index dd5a664c294f..f59890430f40 100644 --- a/fs/xfs/xfs_icache.c +++ b/fs/xfs/xfs_icache.c @@ -88,7 +88,6 @@ xfs_inode_alloc( /* VFS doesn't initialise i_mode or i_state! */ VFS_I(ip)->i_mode = 0; VFS_I(ip)->i_state = 0; - mapping_set_large_folios(VFS_I(ip)->i_mapping);
XFS_STATS_INC(mp, vn_active); ASSERT(atomic_read(&ip->i_pincount) == 0); @@ -323,7 +322,6 @@ xfs_reinit_inode( inode->i_rdev = dev; inode->i_uid = uid; inode->i_gid = gid; - mapping_set_large_folios(inode->i_mapping); return error; }