Re: [PATCH AUTOSEL 5.4 034/134] leds: trigger: netdev: fix handling on interface rename

On Wed 2019-12-11 10:10:10, Sasha Levin wrote:

From: Martin Schiller ms@dev.tdt.de

[ Upstream commit 5f820ed52371b4f5d8c43c93f03408d0dbc01e5b ]

The NETDEV_CHANGENAME code is not "unneeded" like it is stated in commit 4cb6560514fa ("leds: trigger: netdev: fix refcnt leak on interface rename").

The event was accidentally misinterpreted equivalent to NETDEV_UNREGISTER, but should be equivalent to NETDEV_REGISTER.

This was the case in the original code from the openwrt project.

Otherwise, you are unable to set netdev led triggers for (non-existent) netdevices, which has to be renamed. This is the case, for example, for ppp interfaces in openwrt.

Please drop. Pavel