On 03/02/2021 18:15, Subbaraman Narayanamurthy wrote:
"sdam->pdev" is uninitialized and it is used to print error logs. Fix it. Since device pointer can be used from sdam_config, use it directly thereby removing pdev pointer.
Cc: stable@vger.kernel.org Signed-off-by: Subbaraman Narayanamurthy subbaram@codeaurora.org
Applied thanks,
--srini
drivers/nvmem/qcom-spmi-sdam.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/nvmem/qcom-spmi-sdam.c b/drivers/nvmem/qcom-spmi-sdam.c index a72704c..f6e9f96 100644 --- a/drivers/nvmem/qcom-spmi-sdam.c +++ b/drivers/nvmem/qcom-spmi-sdam.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /*
- Copyright (c) 2017, 2020 The Linux Foundation. All rights reserved.
*/
- Copyright (c) 2017, 2020-2021, The Linux Foundation. All rights reserved.
#include <linux/device.h> @@ -18,7 +18,6 @@ #define SDAM_PBS_TRIG_CLR 0xE6 struct sdam_chip {
- struct platform_device *pdev; struct regmap *regmap; struct nvmem_config sdam_config; unsigned int base;
@@ -65,7 +64,7 @@ static int sdam_read(void *priv, unsigned int offset, void *val, size_t bytes) { struct sdam_chip *sdam = priv;
- struct device *dev = &sdam->pdev->dev;
- struct device *dev = sdam->sdam_config.dev; int rc;
if (!sdam_is_valid(sdam, offset, bytes)) { @@ -86,7 +85,7 @@ static int sdam_write(void *priv, unsigned int offset, void *val, size_t bytes) { struct sdam_chip *sdam = priv;
- struct device *dev = &sdam->pdev->dev;
- struct device *dev = sdam->sdam_config.dev; int rc;
if (!sdam_is_valid(sdam, offset, bytes)) {