On Wed, Feb 21, 2024 at 10:51 PM Valentin Obst kernel@valentinobst.de wrote:
Thanks!
Cross checked this as well, can confirm your assessment. Thanks for bringing this up.
My pleasure!
Absolutely, without him reporting the test failure and narrowing down the config I'd have never looked at this file. Adding him for **both** is fair. (This particular fix was not discussed on Zulip though, its just something I noticed along the way.)
In that case, up to you -- whatever you consider fair for this particular patch.
Didn't add it because the discussion does not mention this particular issue, but it might indeed be good for some context.
Makes sense -- I saw the [1] reference and I thought it could be a nice complement to it, but it is true that it may be not that useful, so please feel free to leave it out.
Will this need a v2, or are all of the 'Fixes', 'Reported-By', 'Debugged-By', 'Tested-By', 'Reviewed-By' and 'Link' tags something that maintainers may add when merging?
Typically, tags are picked up by maintainers when they apply the patch (if it is the last version, otherwise you would already pick them up in the next version you send).
However, in this case, since we have the Cc stable@ and you also have the most context to decide on the tags (e.g. for the Reported-by etc.), I would send a v2.
Thanks!
Cheers, Miguel