Re: [PATCH 1/4] net: fix uninitialised access in mii_nway_restart()

On Wed, 19 Mar 2025 11:21:53 +0000 Qasim Ijaz wrote:

--- a/drivers/net/mii.c +++ b/drivers/net/mii.c @@ -464,6 +464,8 @@ int mii_nway_restart (struct mii_if_info *mii) /* if autoneg is off, it's an error */ bmcr = mii->mdio_read(mii->dev, mii->phy_id, MII_BMCR);

• if (bmcr < 0)

• return bmcr;
  

if (bmcr & BMCR_ANENABLE) { bmcr |= BMCR_ANRESTART;

We error check just one mdio_read() but there's a whole bunch of them in this file. What's the expected behavior then? Are all of them buggy?

This patch should be split into core and driver parts.