Re: [PATCH] PCI: imx: fix device node reference leak in imx_pcie_probe

On Wed, Sep 03, 2025 at 09:51:50PM +0800, Miaoqian Lin wrote:

Subject: PCI: imx: Add missing of_node_put() to fix device node reference leak

As the doc of of_parse_phandle() states: "The device_node pointer with refcount incremented. Use

• of_node_put() on it when done."

Needn't this paragaph

Frank

Add missing of_node_put() after of_parse_phandle() call to properly release the device node reference.

Found via static analysis.

Fixes: 1df82ec46600 ("PCI: imx: Add workaround for e10728, IMX7d PCIe PLL failure") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin linmq006@gmail.com

---

drivers/pci/controller/dwc/pci-imx6.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 80e48746bbaf..618bc4b08a8b 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1636,6 +1636,7 @@ static int imx_pcie_probe(struct platform_device *pdev) struct resource res;

ret = of_address_to_resource(np, 0, &res);

• of_node_put(np);
  

  if (ret) { dev_err(dev, "Unable to map PCIe PHY\n"); return ret;

-- 2.35.1