Hi, Javier:
On Fri, 2024-10-11 at 21:21 +0200, Javier Carrasco wrote:
External email : Please do not click links or open attachments until you have verified the sender or the content. Early exits (goto, break, return) from for_each_child_of_node() required an explicit call to of_node_put(), which was not introduced with the break if cnt == MAX_CRTC.
Add the missing of_node_put() before the break.
Reviewed-by: CK Hu ck.hu@mediatek.com
Cc: stable@vger.kernel.org Fixes: d761b9450e31 ("drm/mediatek: Add cnt checking for coverity issue")
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index a4594f8873d5..0878df832859 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -406,8 +406,10 @@ static bool mtk_drm_get_all_drm_priv(struct device *dev) if (temp_drm_priv->mtk_drm_bound) cnt++; -if (cnt == MAX_CRTC) +if (cnt == MAX_CRTC) { +of_node_put(node); break; +} } if (drm_priv->data->mmsys_dev_num == cnt) {
-- 2.43.0