Re: [PATCH] f2fs: fix out-of-repair __setattr_copy()

On 2020/12/16 17:44, Greg KH wrote:

On Wed, Dec 16, 2020 at 05:15:23PM +0800, Chao Yu wrote:

...

__setattr_copy() was copied from setattr_copy() in fs/attr.c, there is two missing patches doesn't cover this inner function, fix it.

Commit 7fa294c8991c ("userns: Allow chown and setgid preservation") Commit 23adbe12ef7d ("fs,userns: Change inode_capable to capable_wrt_inode_uidgid")

Are these lines supposed to be "Fixes:" instead of "Commit "?

IMO, the issue was introduced when f2fs module was added, and above two commits missed to cover f2fs module... so I guess we can add Fixes line as below?

Fixes: fbfa2cc58d53 ("f2fs: add file operations")

Thanks,

thanks,

greg k-h .