An object initialized via device_get_named_child_node() requires calls to fwnode_handle_put() when it is no longer required to avoid leaking memory.
Add the missing calls to fwnode_handle_put() in the different paths (error paths and normal exit).
Cc: stable@vger.kernel.org Fixes: 736214b4b02a ("leds: max5970: Add support for max5970") Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com --- drivers/leds/leds-max5970.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/leds/leds-max5970.c b/drivers/leds/leds-max5970.c index 56a584311581..c021330e0ae7 100644 --- a/drivers/leds/leds-max5970.c +++ b/drivers/leds/leds-max5970.c @@ -72,6 +72,7 @@ static int max5970_led_probe(struct platform_device *pdev)
ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); if (!ddata) { + fwnode_handle_put(led_node); fwnode_handle_put(child); return -ENOMEM; } @@ -89,11 +90,14 @@ static int max5970_led_probe(struct platform_device *pdev)
ret = devm_led_classdev_register(dev, &ddata->cdev); if (ret < 0) { + fwnode_handle_put(led_node); fwnode_handle_put(child); return dev_err_probe(dev, ret, "Failed to initialize LED %u\n", reg); } }
+ fwnode_handle_put(led_node); + return ret; }