lan9303_handle_reset never returns anything other than success. So there's not need for it to return an error code.
Signed-off-by: Phil Reid preid@electromag.com.au --- drivers/net/dsa/lan9303-core.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c index b471413..cc00308 100644 --- a/drivers/net/dsa/lan9303-core.c +++ b/drivers/net/dsa/lan9303-core.c @@ -550,18 +550,16 @@ static int lan9303_separate_ports(struct lan9303 *chip) LAN9303_SWE_PORT_STATE_BLOCKING_PORT2); }
-static int lan9303_handle_reset(struct lan9303 *chip) +static void lan9303_handle_reset(struct lan9303 *chip) { if (!chip->reset_gpio) - return 0; + return;
if (chip->reset_duration != 0) msleep(chip->reset_duration);
/* release (deassert) reset and activate the device */ gpiod_set_value_cansleep(chip->reset_gpio, 0); - - return 0; }
/* stop processing packets for all ports */ @@ -855,9 +853,7 @@ int lan9303_probe(struct lan9303 *chip, struct device_node *np)
lan9303_probe_reset_gpio(chip, np);
- ret = lan9303_handle_reset(chip); - if (ret) - return ret; + lan9303_handle_reset(chip);
ret = lan9303_check_device(chip); if (ret)