Re: [PATCH net v3] mctp i2c: handle NULL header address

On Tue, Oct 22, 2024 at 06:25:14PM +0800, Matt Johnston wrote:

daddr can be NULL if there is no neighbour table entry present, in that case the tx packet should be dropped.

saddr will usually be set by MCTP core, but check for NULL in case a packet is transmitted by a different protocol.

Fixes: f5b8abf9fc3d ("mctp i2c: MCTP I2C binding driver") Cc: stable@vger.kernel.org Reported-by: Dung Cao dung@os.amperecomputing.com Signed-off-by: Matt Johnston matt@codeconstruct.com.au

---

Changes in v3:

• Revert to simpler saddr check of v1, mention in commit message
• Revert whitespace change from v2
• Link to v2: https://lore.kernel.org/r/20241021-mctp-i2c-null-dest-v2-1-4503e478517c@code...

Changes in v2:

• Set saddr to device address if NULL, mention in commit message
• Fix patch prefix formatting
• Link to v1: https://lore.kernel.org/r/20241018-mctp-i2c-null-dest-v1-1-ba1ab52966e9@code...

Thanks for the updates Matt.

Reviewed-by: Simon Horman horms@kernel.org