Re: [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod

On Mon, Aug 11, 2025 at 1:30 PM Markus Elfring Markus.Elfring@web.de wrote:

…

...

+++ b/drivers/scsi/pm8001/pm8001_init.c

…

...

@@ -1226,6 +1227,16 @@ static void pm8001_pci_remove(struct pci_dev *pdev) tasklet_kill(&pm8001_ha->tasklet[j]); #endif scsi_host_put(pm8001_ha->shost);

• for (i = 0; i < pm8001_ha->ccb_count; i++) {
  

•         dma_free_coherent(&pm8001_ha->pdev->dev,
  

•                 sizeof(struct pm8001_prd) * PM8001_MAX_DMA_SG,
  

•                 pm8001_ha->ccb_info[i].buf_prd,
  

•                 pm8001_ha->ccb_info[i].ccb_dma_handle);
  

• }
  

May curly brackets be omitted here? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu...

Thanks, Markus. I agree with you and have no objection. However, for the stable branches, we usually keep the patches unchanged. I think it would be good to remove these curly braces in the Linux master branch as well. Should I go ahead and submit a patch for the master branch too?

Regards, Shivani