The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-4.19.y git checkout FETCH_HEAD git cherry-pick -x 55c421b364482b61c4c45313a535e61ed5ae4ea3 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to 'stable@vger.kernel.org' --in-reply-to '2024061231-player-lumpish-af5c@gregkh' --subject-prefix 'PATCH 4.19.y' HEAD^..
Possible dependencies:
55c421b36448 ("mmc: davinci: Don't strip remove function when driver is builtin") bc1711e8332d ("mmc: davinci_mmc: Convert to platform remove callback returning void") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions") fa6c12e036c9 ("drm/xe/guc: Add Relay Communication ABI definitions")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 55c421b364482b61c4c45313a535e61ed5ae4ea3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= u.kleine-koenig@pengutronix.de Date: Sun, 24 Mar 2024 12:40:17 +0100 Subject: [PATCH] mmc: davinci: Don't strip remove function when driver is builtin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
Using __exit for the remove function results in the remove callback being discarded with CONFIG_MMC_DAVINCI=y. When such a device gets unbound (e.g. using sysfs or hotplug), the driver is just removed without the cleanup being performed. This results in resource leaks. Fix it by compiling in the remove callback unconditionally.
This also fixes a W=1 modpost warning:
WARNING: modpost: drivers/mmc/host/davinci_mmc: section mismatch in reference: davinci_mmcsd_driver+0x10 (section: .data) -> davinci_mmcsd_remove (section: .exit.text)
Fixes: b4cff4549b7a ("DaVinci: MMC: MMC/SD controller driver for DaVinci family") Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20240324114017.231936-2-u.kleine-koenig@pengutroni... Signed-off-by: Ulf Hansson ulf.hansson@linaro.org
diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 8bd938919687..d7427894e0bc 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -1337,7 +1337,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev) return ret; }
-static void __exit davinci_mmcsd_remove(struct platform_device *pdev) +static void davinci_mmcsd_remove(struct platform_device *pdev) { struct mmc_davinci_host *host = platform_get_drvdata(pdev);
@@ -1392,7 +1392,7 @@ static struct platform_driver davinci_mmcsd_driver = { .of_match_table = davinci_mmc_dt_ids, }, .probe = davinci_mmcsd_probe, - .remove_new = __exit_p(davinci_mmcsd_remove), + .remove_new = davinci_mmcsd_remove, .id_table = davinci_mmc_devtype, };