On Mon, May 21, 2018 at 05:39:32PM +0100, James Hogan wrote:
On Sun, Apr 08, 2018 at 10:30:03AM +0200, Mathias Kresin wrote:
While doing a global software reset, these bits are not cleared and let some bootloader fail to initialise the GPHYs. The bootloader don't expect the GPHYs in reset, as they aren't during power on.
The asserts were a workaround for a wrong syscon-reboot mask. With a mask set which includes the GPHY resets, these resets aren't required any more.
Fixes: 126534141b45 ("MIPS: lantiq: Add a GPHY driver which uses the RCU syscon-mfd") Cc: stable@vger.kernel.org # 4.14+ Signed-off-by: Mathias Kresin dev@kresin.me
Applied for 4.17. Thanks for the acks/reviews folk!
drivers/soc/lantiq/gphy.c: In function ‘xway_gphy_remove’: drivers/soc/lantiq/gphy.c:198:6: warning: unused variable ‘ret’ [-Wunused-variable] int ret; ^~~ drivers/soc/lantiq/gphy.c:196:17: warning: unused variable ‘dev’ [-Wunused-variable] struct device *dev = &pdev->dev; ^~~
Easily fixed, I can drop those two lines:
diff --git a/drivers/soc/lantiq/gphy.c b/drivers/soc/lantiq/gphy.c index 8c31ae750987..feeb17cebc25 100644 --- a/drivers/soc/lantiq/gphy.c +++ b/drivers/soc/lantiq/gphy.c @@ -193,9 +193,7 @@ static int xway_gphy_probe(struct platform_device *pdev)
static int xway_gphy_remove(struct platform_device *pdev) { - struct device *dev = &pdev->dev; struct xway_gphy_priv *priv = platform_get_drvdata(pdev); - int ret;
iowrite32be(0, priv->membase);
However it does raise the question, it sounds like a fix, but was this patch tested and the warning just overlooked?
Cheers James