Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on() call placement

On Wed, 6 Aug 2025 01:40:37 +0300 Linus Torvalds wrote:

So my gut feel is that the

            if (test_and_clear_bit(EVENT_LINK_CARRIER_ON, &dev->flags))
                    netif_carrier_on(dev->net);

should actually be done outside that if-statement entirely, because it literally ends up changing the thing that if-statement is testing.

Right. I think it should be before the if (!netif_carrier_ok(dev->net))

Ammar, could you retest and repost that, since we haven't heard from John?