Re: [PATCH] mm: mempolicy: make mbind() return -EIO when MPOL_MF_STRICT is specified

On 3/20/19 3:16 PM, Andrew Morton wrote:

On Wed, 20 Mar 2019 11:23:03 +0530 Souptick Joarder jrdr.linux@gmail.com wrote:

...

...

--- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -447,6 +447,13 @@ static inline bool queue_pages_required(struct page *page, return node_isset(nid, *qp->nmask) == !(flags & MPOL_MF_INVERT); }

+/*

• • The queue_pages_pmd() may have three kind of return value.
• • 1 - pages are placed on he right node or queued successfully.

Minor typo -> s/he/the ?

Yes, that comment needs some help. This?

--- a/mm/mempolicy.c~mm-mempolicy-make-mbind-return-eio-when-mpol_mf_strict-is-specified-fix +++ a/mm/mempolicy.c @@ -429,9 +429,9 @@ static inline bool queue_pages_required( } /*

• • The queue_pages_pmd() may have three kind of return value.
• • 1 - pages are placed on he right node or queued successfully.
• • 0 - THP get split.

• • queue_pages_pmd() has three possible return values:
• • 1 - pages are placed on the right node or queued successfully.
• • 0 - THP was split.
  • -EIO - is migration entry or MPOL_MF_STRICT was specified and an existing

  •    page was already on a node that does not follow the policy.
    

  */

It looks good to me. Thanks, Andrew.

Yang

_