Re: [PATCH] scsi: st: Regression fix: Don't set pos_unknown just after device recognition

On 12/16/24 3:37 AM, Kai Mäkisara wrote:

diff --git a/drivers/scsi/st.h b/drivers/scsi/st.h index 7a68eaba7e81..1aaaf5369a40 100644 --- a/drivers/scsi/st.h +++ b/drivers/scsi/st.h @@ -170,6 +170,7 @@ struct scsi_tape { unsigned char rew_at_close; /* rewind necessary at close */ unsigned char inited; unsigned char cleaning_req; /* cleaning requested? */

• unsigned char first_tur; /* first TEST UNIT READY */ int block_size; int min_block; int max_block;

Why 'unsigned char' instead of 'bool'?

Should perhaps all 'unsigned char' occurrences in struct scsi_tape be changed into 'bool'? I'm not aware of any other Linux kernel code that uses the type 'unsigned char' for boolean values.

Thanks,

Bart.