Re: [PATCH 4.19.y] tracing: Reject string operand in the histogram expression

On Wed, Aug 11, 2021 at 04:39:46PM +0900, Masami Hiramatsu wrote:

commit a9d10ca4986571bffc19778742d508cc8dd13e02 upstream

Since the string type can not be the target of the addition / subtraction operation, it must be rejected. Without this fix, the string type silently converted to digits.

Link: https://lkml.kernel.org/r/162742654278.290973.1523000673366456634.stgit@devn...

Cc: stable@vger.kernel.org Fixes: 100719dcef447 ("tracing: Add simple expression support to hist triggers") Signed-off-by: Masami Hiramatsu mhiramat@kernel.org Signed-off-by: Steven Rostedt (VMware) rostedt@goodmis.org

---

• Since there is no hist_err() APIs in 4.19, this just check the flag and return an error without any error messages.

---

kernel/trace/trace_events_hist.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)

Both backports applied, thanks.

greg k-h