The quilt patch titled Subject: Revert "mm/compaction: fix set skip in fast_find_migrateblock" has been removed from the -mm tree. Its filename was revert-mm-compaction-fix-set-skip-in-fast_find_migrateblock.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------ From: Vlastimil Babka vbabka@suse.cz Subject: Revert "mm/compaction: fix set skip in fast_find_migrateblock" Date: Fri, 13 Jan 2023 18:33:45 +0100
This reverts commit 7efc3b7261030da79001c00d92bc3392fd6c664c.
We have got openSUSE reports (Link 1) for 6.1 kernel with khugepaged stalling CPU for long periods of time. Investigation of tracepoint data shows that compaction is stuck in repeating fast_find_migrateblock() based migrate page isolation, and then fails to migrate all isolated pages. Commit 7efc3b726103 ("mm/compaction: fix set skip in fast_find_migrateblock") was suspected as it was merged in 6.1 and in theory can indeed remove a termination condition for fast_find_migrateblock() under certain conditions, as it removes a place that always marks a scanned pageblock from being re-scanned. There are other such places, but those can be skipped under certain conditions, which seems to match the tracepoint data.
Testing of revert also appears to have resolved the issue, thus revert the commit until a more robust solution for the original problem is developed.
It's also likely this will fix qemu stalls with 6.1 kernel reported in Link 2, but that is not yet confirmed.
Link: https://bugzilla.suse.com/show_bug.cgi?id=1206848 Link: https://lore.kernel.org/kvm/b8017e09-f336-3035-8344-c549086c2340@kernel.org/ Link: https://lkml.kernel.org/r/20230113173345.9692-1-vbabka@suse.cz Fixes: 7efc3b726103 ("mm/compaction: fix set skip in fast_find_migrateblock") Signed-off-by: Vlastimil Babka vbabka@suse.cz Tested-by: Jiri Slaby jirislaby@kernel.org Tested-by: Pedro Falcato pedro.falcato@gmail.com Cc: Chuyi Zhou zhouchuyi@bytedance.com Cc: Maxim Levitsky mlevitsk@redhat.com Cc: Mel Gorman mgorman@techsingularity.net Cc: Michal Hocko mhocko@kernel.org Cc: Paolo Bonzini pbonzini@redhat.com Cc: Thorsten Leemhuis regressions@leemhuis.info Cc: stable@vger.kernel.org Signed-off-by: Andrew Morton akpm@linux-foundation.org ---
--- a/mm/compaction.c~revert-mm-compaction-fix-set-skip-in-fast_find_migrateblock +++ a/mm/compaction.c @@ -1839,6 +1839,7 @@ static unsigned long fast_find_migratebl pfn = cc->zone->zone_start_pfn; cc->fast_search_fail = 0; found_block = true; + set_pageblock_skip(freepage); break; } } _
Patches currently in -mm which might be from vbabka@suse.cz are
mm-mremap-fix-mremap-expanding-for-vmas-with-vm_ops-close.patch mm-use-stack_depot_early_init-for-kmemleak-fix.patch