Re: [PATCH 4.19 068/422] ASoC: meson: axg-fifo: report interrupt request failure

Hi!

Return value of request_irq() was irgnored. Fix this and report the failure if any

1 file changed, 2 insertions(+)

diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c index 30262550e37b1..0e4f65e654c4b 100644 --- a/sound/soc/meson/axg-fifo.c +++ b/sound/soc/meson/axg-fifo.c @@ -203,6 +203,8 @@ static int axg_fifo_pcm_open(struct snd_pcm_substream *ss) ret = request_irq(fifo->irq, axg_fifo_pcm_irq_block, 0, dev_name(dev), ss);

• if (ret)

• return ret;
  

/* Enable pclk to access registers and clock the fifo ip */ ret = clk_prepare_enable(fifo->pclk);

While this is not incorrect...

Do we need to free_irq in case of clk_prepare_enable() or other stuff below fails?

Best regards, Pavel