Hi Bart,
Thanks for the review.
On Fri, 14 Mar 2025 at 16:01, Bart Van Assche bvanassche@acm.org wrote:
On 3/14/25 8:38 AM, Peter Griffin wrote:
ufs-exynos driver enables the shareability option for gs101 which means the descriptors need to be allocated as cacheable.
Shouldn't that code be modified such that the shareability option is only set if the dma-coherent property is present in the device tree?
Yes, I plan to add an extra patch that does what you describe into the v2 of the UFS fixes series [1] likely later today.
I sent this out separately for Krzysztof's Exynos DT tree in the hope he will pick it up in the next -rc as this patch fixes how the driver is configured today, and is also still the configuration we want once the driver changes land. I should have made that a bit clearer in the cover letter :)
Thanks,
Peter
[1] https://lore.kernel.org/linux-scsi/20250226220414.343659-1-peter.griffin@lin...