question: drop because of upstream's
cbe095e2b584 ("Revert "scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte()"") Fixes: e39a97353e53 ("scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte()")
as in stable-queue's
c40541008b93 ("drop a scsi patch from 4.14")
?
On 05/28/2018 11:59 AM, Greg Kroah-Hartman wrote:
4.14-stable review patch. If anyone has any objections, please let me know.
From: Hannes Reinecke hare@suse.de
[ Upstream commit e39a97353e5378eb46bf01679799c5704d397f32 ]
When converting __scsi_error_from_host_byte() to BLK_STS error codes the case DID_OK was forgotten, resulting in it always returning an error.
Fixes: 2a842acab109 ("block: introduce new block status code type") Cc: Doug Gilbert dgilbert@interlog.com Signed-off-by: Hannes Reinecke hare@suse.com Reviewed-by: Douglas Gilbert dgilbert@interlog.com Signed-off-by: Martin K. Petersen martin.petersen@oracle.com Signed-off-by: Sasha Levin alexander.levin@microsoft.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
drivers/scsi/scsi_lib.c | 2 ++ 1 file changed, 2 insertions(+)
--- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -720,6 +720,8 @@ static blk_status_t __scsi_error_from_ho int result) { switch (host_byte(result)) {
- case DID_OK:
return BLK_STS_OK;